Implement stream connection for remote write #6580
Merged
+1,157
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
anna-tran
reviewed
Feb 7, 2025
anna-tran
reviewed
Feb 7, 2025
|
I am ok with this change. Lets get more feedback |
…-stream-push Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Mar 27, 2025
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Apr 3, 2025
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
May 13, 2025
There was a problem hiding this comment.
Can we mention this in https://cortexmetrics.io/docs/configuration/v1guarantees/ as experimental feature?
And can we add a simple integration test just to ensure this works E2E?
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
May 15, 2025
Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Introduced stream connection for RemoteWrite endpoint. Keep stream connection open on ingester side could reduce the CPU usage on ingester to open new connection each time accepting new RemoteWrite requests.
Here is the comparison between normal connection and stream connection:
Tested with 6000 TPS
Compared to normal connection, stream connection could have 8%-9% less CPU usage.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]